Re: [patch 23/23] dynticks: decrease I8042_POLL_PERIOD

[Andrew Morton]

On Fri, 29 Sep 2006 23:58:43 -0000
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> From: Ingo Molnar <mingo@xxxxxxx>
> 
> decrease the rate of timers going off. Also work around apparent
> kbd-init bug by making the first timeout short.
> 

Again, please don't make unrelated kernel functions behave differently like
this.

> 
> Index: linux-2.6.18-mm2/drivers/input/serio/i8042.c
> ===================================================================
> --- linux-2.6.18-mm2.orig/drivers/input/serio/i8042.c	2006-09-30 01:41:08.000000000 +0200
> +++ linux-2.6.18-mm2/drivers/input/serio/i8042.c	2006-09-30 01:41:20.000000000 +0200
> @@ -1101,7 +1101,7 @@ static int __devinit i8042_probe(struct 
>  		goto err_controller_cleanup;
>  	}
>  
> -	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
> +	mod_timer(&i8042_timer, jiffies + 2); //I8042_POLL_PERIOD);
>  	return 0;
>  
>   err_unregister_ports:
> Index: linux-2.6.18-mm2/drivers/input/serio/i8042.h
> ===================================================================
> --- linux-2.6.18-mm2.orig/drivers/input/serio/i8042.h	2006-09-30 01:41:08.000000000 +0200
> +++ linux-2.6.18-mm2/drivers/input/serio/i8042.h	2006-09-30 01:41:20.000000000 +0200
> @@ -43,7 +43,7 @@
>   * polling.
>   */
>  
> -#define I8042_POLL_PERIOD	HZ/20
> +#define I8042_POLL_PERIOD	(10*HZ)

That's a huge change.  Perhaps the interval was too short in the first
case.  I guess waiting ten seconds for your keyboard or mouse to come to
life after hot-add is liveable with.

But whatever.  This timer gets deleted in Dmitry's current development tree:

commit de9ce703c6b807b1dfef5942df4f2fadd0fdb67a
Author: Dmitry Torokhov <dtor@xxxxxxxxxxxxx>
Date:   Sun Sep 10 21:57:21 2006 -0400

    Input: i8042 - get rid of polling timer
    
    Remove polling timer that was used to detect keybord/mice hotplug and
    register both IRQs right away instead of waiting for a driver to
    attach to a port.
    
    Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>

so problem solved.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/