Re: [patch 2.6.18-git] RTC class uses subsys_init

From: Andrew Morton
Date: Sun Oct 01 2006 - 05:20:56 EST


On Sun, 1 Oct 2006 11:07:17 +0200
Olaf Hering <olaf@xxxxxxxxx> wrote:

> On Thu, Sep 28, David Brownell wrote:
>
>
> > +++ linux/drivers/rtc/rtc-sysfs.c 2006-07-30 16:15:50.000000000 -0700
> > @@ -116,7 +116,7 @@
> > class_interface_unregister(&rtc_sysfs_interface);
> > }
> >
> > -module_init(rtc_sysfs_init);
> > +subsys_init(rtc_sysfs_init);
> > module_exit(rtc_sysfs_exit);
>
> subsys_init is not defined, but the change is in Linus tree now.

doh. But it still compiled.

drivers/rtc/rtc-sysfs.c:119: warning: data definition has no type or storage class
drivers/rtc/rtc-sysfs.c:119: warning: type defaults to 'int' in declaration of 'subsys_init'
drivers/rtc/rtc-sysfs.c:119: warning: parameter names (without types) in function declaration
drivers/rtc/rtc-sysfs.c:110: warning: 'rtc_sysfs_init' defined but not used

I'll fix it up.

(Wonders how it passed runtime testing..)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/