Re: [PATCH] ISDN: mark as 32-bit only

[Karsten Keil]

On Sun, Oct 01, 2006 at 11:21:16AM -0400, Jeff Garzik wrote:
> 
> Tons of ISDN drivers cast pointers to/from 32-bit values, which just
> won't work on 64-bit.
> 

NACK.

This is no problem for ISDN only some old HW drivers may not work (for most
I do not have any hardware by myself). 
I will compile all drivers again and if here are 64 bit issues I will
disable the drivers, not ISDN.

ISDN works on 64 bits, at least with following protocols:
- transparent (audio/voice)
- X.75
- HDLC
- sync PPP

Maybe some other protocols need some 64 bit cleanup, but last time I audited
the ISDN core code for 64 bit I did not saw any problems.
My main test machines are 64 bit (and SMP) and they are running ISDN servers
for sync PPP and voice data processing on different ISDN HW and drivers
(CAPI and Hisax) without any problem.

You will see still some warnings in the CAPI code, because the capi code
has dual 64/32 bit protocol format for data packets (has 2 different pointer
areas one for 64 bit one for32 bit), but this is OK.

> Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>
> 
> diff --git a/drivers/isdn/Kconfig b/drivers/isdn/Kconfig
> index c90afee..608588f 100644
> --- a/drivers/isdn/Kconfig
> +++ b/drivers/isdn/Kconfig
> @@ -6,7 +6,7 @@ menu "ISDN subsystem"
>  
>  config ISDN
>  	tristate "ISDN support"
> -	depends on NET
> +	depends on NET && 32BIT
>  	---help---
>  	  ISDN ("Integrated Services Digital Networks", called RNIS in France)
>  	  is a special type of fully digital telephone service; it's mostly

-- 
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/