Re: [patch 2.6.18-git] SPI -- Freescale iMX SPI controller driver

[Thiago Galesi]

<nitpickery on>
+
> +/*-------------------------------------------------------------------------*/
> +/* SPI Control Register Bit Fields & Masks */
> +#define SPI_CONTROL_BITCOUNT   (0xF)           /* Bit Count Mask */
> +#define SPI_CONTROL_BITCOUNT_1 (0x0)           /* Bit Count = 1 */
> +#define SPI_CONTROL_BITCOUNT_2 (0x1)           /* Bit Count = 2 */
> +#define SPI_CONTROL_BITCOUNT_3 (0x2)           /* Bit Count = 3 */

I thinking these comments are awfully confusing (bitcount_1 == 0
?!?!?) and maybe redundant.

It would be much more useful to explain the logic behind why
(bitcount_1 == 0) and remove the /* Bit Count = X */ comments


> +/* SPI Soft Reset Register Bit Fields & Masks */
> +#define SPI_RESET_START                (0x1 << 0)      /* Start */

Wouldn't only (0x1) be better?

> +
> +/* Message state */
> +#define START_STATE                    ((void*)0)
> +#define RUNNING_STATE                  ((void*)1)
> +#define DONE_STATE                     ((void*)2)
> +#define ERROR_STATE                    ((void*)-1)

!?!??!?!

All in all, except for what Andrew has pointed out, it looks good,
maybe a little bit overengineered...

--
-
Thiago Galesi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/