Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning

From: David Brownell
Date: Mon Oct 02 2006 - 16:05:40 EST


On Monday 02 October 2006 10:45 am, Alan Cox wrote:
> Ar Llu, 2006-10-02 am 09:02 -0700, ysgrifennodd David Brownell:
> > Git rid of the runtime warning about pcmcia not supporting
> > exclusive IRQs, so "the driver needs updating".
> >
> > Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
>
> You've audited the code to check this is safely handled ?

As best I can, yes. IDE being somewhat black-boxish to most of us.
The patch literally does no more than shut up the warning found in
drivers/pcmcia/pcmcia_resource.c ... it doesn't change any other
behavior in the PCMCIA layer. And the IDE layer never appeared to
have a problem.

The IRQ handler seems to be drivers/ide/ide-io.c::ide_intr() and
comments there reflect the expectation that it handle shared IRQs.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/