[PATCH 1/6] Char: mxser_new, revert spin_lock changes

From: Jiri Slaby
Date: Tue Oct 03 2006 - 18:05:12 EST


mxser_new, revert spin_lock changes

Some spinlock changes were introduced in 1.9.1 original moxa driver. Revert
them, since they cause machine not responding.

Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>

---
commit 4c32efcfdb10227313ef7271ffc4658dbdf2d81c
tree 38ec2fc437a458f796279818fbadfacf8ead43ab
parent e92271cac3db8e9f64b79132553e607e8c84f42d
author Jiri Slaby <jirislaby@xxxxxxxxx> Tue, 03 Oct 2006 22:25:27 +0200
committer Jiri Slaby <xslaby@xxxxxxxxxxxxxxxxxx> Tue, 03 Oct 2006 22:25:27 +0200

drivers/char/mxser_new.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 4e881ac..db89d73 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -1687,22 +1687,12 @@ static void mxser_startrx(struct tty_str
*/
static void mxser_throttle(struct tty_struct *tty)
{
- struct mxser_port *info = tty->driver_data;
- unsigned long flags;
-
- spin_lock_irqsave(&info->slock, flags);
mxser_stoprx(tty);
- spin_unlock_irqrestore(&info->slock, flags);
}

static void mxser_unthrottle(struct tty_struct *tty)
{
- struct mxser_port *info = tty->driver_data;
- unsigned long flags;
-
- spin_lock_irqsave(&info->slock, flags);
mxser_startrx(tty);
- spin_unlock_irqrestore(&info->slock, flags);
}

static void mxser_set_termios(struct tty_struct *tty, struct termios *old_termios)
@@ -1930,7 +1920,6 @@ static irqreturn_t mxser_interrupt(int i
}
/* above add by Victor Yu. 09-13-2002 */

- spin_lock(&port->slock);
/* following add by Victor Yu. 09-02-2002 */
status = inb(port->ioaddr + UART_LSR);

@@ -1981,7 +1970,6 @@ static irqreturn_t mxser_interrupt(int i
if (status & UART_LSR_THRE)
mxser_transmit_chars(port);
}
- spin_unlock(&port->slock);
} while (int_cnt++ < MXSER_ISR_PASS_LIMIT);
}
if (pass_counter++ > MXSER_ISR_PASS_LIMIT)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/