Re: [RFC PATCH] add pci_{request,free}_irq take #2

[Matthew Wilcox]

On Tue, Oct 03, 2006 at 06:37:12PM -0400, Jeff Garzik wrote:
> Frederik Deweerdt wrote:
> >My bad, I've mixed your proposal and Matthew's, isn't this just a
> >matter of:
> >s/ARCH_VALIDATE_PCI_IRQ/ARCH_VALIDATE_IRQ/ ?
> >
> >I'll look if there's some non-PCI code that might check the irq's value
> >and thus might benefit from this.
> 
> The irq value comes from the PCI subsystem...  The PCI subsystem should 
> validate it.

That's not true.  The value in the pci_dev->irq field has been changed
by the architecture.  See, for example, pci_read_irq_line() in
arch/powerpc/kernel/pci_32.c.  It's a Linux IRQ number, not a PCI IRQ
number.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/