Re: [RFC PATCH] move tg3 to pci_request_irq

[Frederik Deweerdt]

On Tue, Oct 03, 2006 at 11:27:48PM -0700, David Miller wrote:
> From: Jeff Garzik <jeff@xxxxxxxxxx>
> Date: Wed, 04 Oct 2006 01:38:31 -0400
> 
> > As for why the flag may be missing -- PCI MSI interrupts are never 
> > shared.  However, it won't _hurt_ anything to set the flag needlessly, 
> > AFAIK.
> 
> That's right.
Just to make sure I understood: does this means that the code at lines
296 and 297 in e1000_main.c can be safely removed?

 296 if (adapter->have_msi)
 297 	flags &= ~IRQF_SHARED;
 298 #endif
 299 if ((err = request_irq(adapter->pdev->irq, &e1000_intr, flags,
 300 	netdev->name, netdev)))
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/