Re: [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fixrescan_partitions to return errors properly - take 2)

[Andrew Morton]

On Fri, 06 Oct 2006 18:46:18 -0700
Suzuki K P <suzuki@xxxxxxxxxx> wrote:

> *  The check_partition() stops its probe once it hits an I/O error from the partition checkers. This would prevent the actual partition checker getting a chance to verify the partition. So, this patch lets the check_partition continue probing untill it hits a success while recording the I/O error which might have been reported by the checking routines.
> 
> Also, it does some cleanup of the partition methods for ibm, atari and amiga to return -1 upon hitting an I/O error.

What is the significance of a `return 1', a `return 0' and a `return -EFOO' in these
functions?  It all looks rather odd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/