Re: [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi()

[Jeff Garzik]

Grant Grundler wrote:
> On Fri, Oct 06, 2006 at 03:59:57PM -0400, Jeff Garzik wrote:
> > The unmodified tulip driver checks both MWI and cacheline-size because 
> > one of the clones (PNIC or PNIC2) will let you set the MWI bit, but 
> > hardwires cacheline size to zero.
>
> Maybe the generic pci_set_mwi() can verify cacheline size is non-zero?
> I don't think each driver should need to enforce this.

Agreed.


> > If the arches do not behave consistently, we need to keep the check in 
> > the tulip driver, to avoid incorrectly programming the csr0 MWI bit.
>
> Why not fix the arches to be consistent?
> There's alot more drivers than arches...and we have control
> of the arch specific PCI support.

Agreed.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/