Re: [PATCH] apparent typo in ixgb.h, "_DEBUG_DRIVER_" looks wrong

From: Alexey Dobriyan
Date: Tue Oct 10 2006 - 05:15:36 EST


On Tue, Oct 10, 2006 at 02:27:34AM -0400, Robert P. J. Day wrote:
> I'm *guessing* that "_DEBUG_DRIVER_" should really be "DEBUG_DRIVER"
> here, since there is no other occurrence of the former anywhere in the
> source tree.

Since it's debugging guard, underscored or not... doesn't matter. Convert to
pr_debug or dev_dbg of you want to deal with it.

> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,7 +77,7 @@ #include "ixgb_hw.h"
> #include "ixgb_ee.h"
> #include "ixgb_ids.h"
>
> -#ifdef _DEBUG_DRIVER_
> +#ifdef DEBUG_DRIVER
> #define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> #else
> #define IXGB_DBG(args...)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/