Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume

From: Pierre Ossman
Date: Thu Oct 12 2006 - 01:55:32 EST


Doesn't Jeff love me anymore? :(

Alex Dubov wrote:
> --- Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
>
>> Date: Wed, 11 Oct 2006 17:48:09 -0400
>> From: Jeff Garzik <jeff@xxxxxxxxxx>
>> To: oakad@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxx>,
>> LKML <linux-kernel@xxxxxxxxxxxxxxx>
>> Subject: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
>>
>>
>> Since pci_enable_device() is one of the first things called in the
>> resume step, take the minimalist approach and return immediately, if
>> pci_enable_device() fails during resume.
>>
>> Also, in sdhci: don't check for impossible condition (chip==NULL)
>>
>> Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>
>>
>>

I'm just being cautious. "This can't happen" is usually the last thing
you here before the end. ;)

Signed-off-by: Pierre Ossman <drzeus@xxxxxxxxx>

Rgds

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/