Re: [linux-usb-devel] [PATCH] usbmon: add binary interface

From: Duncan Sands
Date: Thu Oct 12 2006 - 04:21:36 EST


On Wednesday 11 October 2006 22:43, Pete Zaitcev wrote:
> On Wed, 11 Oct 2006 19:44:43 +0000, Pavel Machek <pavel@xxxxxxx> wrote:
>
> > Does it mean text interface is now deprecated? Or perhaps ioctl should
> > be added to text interface too? Or maybe we do not need binary
> > interface if we allow resizing on text interface?
>
> I haven't reviewed Paolo's patch yet, but with that in mind:
> - No, text is not deprecated yet. That is only possible when a simplified
> command-line tool is written and distributed (e.g. usbmon(8)).
> - No, I do not think an ioctl in debugfs or a text API is a good idea.
> - Resizing on text interface magnifies sprintf contribution to CPU burn,
> so once we have the binary one, there's only disadvantage and
> no advantage in implementing that.

By the way, any reason why CONFIG_USB_MON doesn't select CONFIG_DEBUG_FS?
Is usbmon useful without debugfs?

Ciao,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/