Re: [PATCH] HP mobile data protection system driver

[Burman Yan]

> From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> To: Burman Yan <yan_952@xxxxxxxxxxx>
> CC: davej@xxxxxxxxxx, jesper.juhl@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,  
> pazke@xxxxxxxxx
>
> well.... breaking stuff for no reason other than "but it sounds like HIS
> name" is I thing bad. Yes the name is unfortunate, but if you can use
> the interface... why not? Just because the name isn't perfect everyone
> should change over, including keeping compatibility mess etc etc?
> That needs a stronger reason than "it sounds like his name" to me...
>
> Now if the interface itself isn't good enough, that's a different matter
> of course; but from what I read so far that's not really the case.

You have a point, but the thing is that I hope to make this work interrupt 
driven in the future.
Right now for some reason request_irq fails with ENOSYS (I don't know if 
it's a bios acpi bug, or my bug
or acpi parsing bug yet, although I see that I get the right IRQ - the same 
as that other a bit less
known OS...;) and also request_irq succeeds on xen kernel, but fails on RH 
2.6.17.13 and vanilla 2.6.18).
To make a long story short, the interface should probably be different from 
hdaps'
in the future + hdapsd will have to be modified anyway since I cannot 
provide the functionality
to detect keyboard and mouse activity through the accelerometer, since it 
doesn't support it.

Right now I can emulate hdaps and perhaps I can even provide the same 
methods that will return
dummy result for the stuff I don't have. You think I should emulate hdaps' 
functionalty
that is missing from mdps? I actually didn't look at why hdapsd needs 
keyboard and mouse activity for.
I'm guessing that it's to see if you're using your laptop, since if there is 
activity, chances are
that your laptop is not falling and if it is, it's falling with you along... 
Need to check.

Regards
Yan

_________________________________________________________________
Don't just search. Find. Check out the new MSN Search! 
http://search.msn.click-url.com/go/onm00200636ave/direct/01/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/