Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*

From: Andrew Morton
Date: Fri Oct 13 2006 - 16:38:06 EST


On Fri, 13 Oct 2006 16:07:05 -0400
Josef Sipek <jsipek@xxxxxxxxxxxxxxxxx> wrote:

> > > +static inline void __stackfs_copy_attr_all(struct inode *dest,
> > > + const struct inode *src,
> > > + int (*get_nlinks)(struct inode *))
> > > +{
> > > + if (!get_nlinks)
> > > + dest->i_nlink = src->i_nlink;
> > > + else
> > > + dest->i_nlink = get_nlinks(dest);
> >
> > I cannot find a get_nlinks() in 2.6.19-rc2?
>
> It is the last argument to the function. Perhaps the function name is
> deceiving.

doh.

That's why us old farts like to see

dest->i_nlink = (*get_nlinks)(dest);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/