Re: drivers/base/sys.c bug found

From: Greg KH
Date: Sat Oct 14 2006 - 01:12:50 EST


On Wed, Oct 04, 2006 at 07:38:07AM -0400, Jeff Garzik wrote:
> sysdev_driver::add is defined to return an error (as it should), but
> that error code is never checked.

Ick, good catch.

I hate those sysdev devices...

Hm, in sysdev_driver_register() we don't want to return any error there,
as it doesn't make sense to.

Shaohua, sysdev devices should not stop the notificiation if a single
add() function returns an error, right? All of the individual drivers
want to be notified of the device.

Bleah...did I mention I don't like these things...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/