Re: [PATCH 07/18] V4L/DVB (4733): Tda10086: fix frontend selection for dvb_attach

[Adrian Bunk]

On Sat, Oct 14, 2006 at 09:00:50AM -0300, mchehab@xxxxxxxxxxxxx wrote:
> 
> From: Michael Krufky <mkrufky@xxxxxxxxxxx>
> 
> Signed-off-by: Michael Krufky <mkrufky@xxxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
> ---
> 
>  drivers/media/dvb/frontends/tda10086.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/dvb/frontends/tda10086.h b/drivers/media/dvb/frontends/tda10086.h
> index e8061db..18457ad 100644
> --- a/drivers/media/dvb/frontends/tda10086.h
> +++ b/drivers/media/dvb/frontends/tda10086.h
> @@ -35,7 +35,16 @@ struct tda10086_config
>  	u8 invert;
>  };
>  
> +#if defined(CONFIG_DVB_TDA10086) || defined(CONFIG_DVB_TDA10086_MODULE)
>  extern struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
>  					    struct i2c_adapter* i2c);
> +#else
> +static inline struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
> +						   struct i2c_adapter* i2c)
> +{
> +	printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__);
> +	return NULL;
> +}
> +#endif // CONFIG_DVB_TDA10086

As already said:
This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA10086=m.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/