Re: [PATCH 1/7] Char: stallion, use pr_debug macro

From: Jiri Slaby
Date: Sun Oct 15 2006 - 04:25:28 EST


Richard Knutsson wrote:
Sorry for the late respond, just saw it...

Jiri Slaby wrote:
stallion, use pr_debug macro
As it is a driver, is it not recommended to use the "dev_dbg()" found in include/linux/device.h, instead of pr_debug?

Only iff you have access to struct device. And you don't have here, but 2 prints in stl_initpcibrd. This would be fixed in next patch serie...

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/