Re: undefined reference to highest_possible_node_id

[Geert Uytterhoeven]

On Sun, 15 Oct 2006, Olaf Hering wrote:
> A 2.6.19-rc2 pseries_defconfig build with SMP=n will not link,
> highest_possible_node_id is undefined because NODES_SHIFT == 4.
> How can this be fixed properly?

I noticed the same a few days ago, but only started looking into it a few
minutes ago.

If MAX_NUMNODES is larger than one, highest_possible_node_id() is no longer a
macro, but a real function, defined in lib/cpumask.c.
NEED_MULTIPLE_NODES depends on DISCONTIGMEM || NUMA.

But lib/cpumask.c is compiled only for SMP, causing a link failure if
CONFIG_SUNRPC is enabled, as net/sunrpc/svc.c:svc_pool_map_init_pernode() uses
highest_possible_node_id().

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/