Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did getset

From: Andrew Morton
Date: Sun Oct 15 2006 - 20:15:54 EST


On Mon, 16 Oct 2006 10:00:25 +1000 Paul Mackerras <paulus@xxxxxxxxx> wrote:

> Andrew Morton writes:
>
> > If the drivers doesn't care and if it makes no difference to performance
> > then just delete the call to pci_set_mwi().
> >
> > But if MWI _does_ make a difference to performance then we should tell
> > someone that it isn't working rather than silently misbehaving?
>
> That sounds like we need a printk inside pci_set_mwi then, rather than
> adding a printk to every single caller.
>

I think so, yes. That's a good solution to a lot of these things.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/