Re: Re: [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion

[balagi]

Hello,

the congestion control will work with both code changes, but i am
not sure, if using clear_queue_congested() and blk_congestion_wait()
is the right thing to use here: it works on global level. Any other
thread/driver/etc. can do a clear_queue_congested() and wake
up anyone waiting on this global write or read wait queue, resulting to
unneeded task switches.
The driver local solution (own waitqueue) would prevent this.....

-Thomas Maier


----- original Nachricht --------

Betreff: Re: [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion
Gesendet: So 15 Okt 2006 20:16:31 CEST
Von: "Jens Axboe"<jens.axboe@xxxxxxxxxx>

> On Sat, Oct 14 2006, Peter Osterlund wrote:
> > "Thomas Maier" <balagi@xxxxxxxxxxx> writes:
> > 
> > > Hello,
> > > 
> > > this adds a bio write queue congestion control
> > > to the pktcdvd driver with fixed on/off marks.
> > > It prevents that the driver consumes a unlimited
> > > amount of write requests.
> > 
> > Thanks, this looks good in principle, but I think it can be
> > implemented in a simpler way.
> > 
> > Jens, can I please ask your opinion. Would it make sense to export the
> > clear_queue_congested() and set_queue_congested() functions in
> > ll_rw_blk.c so that the pktcdvd driver can use them? Something like
> > this patch from a few years ago:
> > 
> >        
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109378210610508&w=2
> 
> It definitely would. Did you test, and did it work well for you? I think
> it's the right approach.
> 
> -- 
> Jens Axboe
> 
> 

--- original Nachricht Ende ----









-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/