Re: [PATCH] pata_marvell: Marvell 6101/6145 PATA driver

From: Jeff Garzik
Date: Mon Oct 16 2006 - 19:49:02 EST


Andrew Morton wrote:
On Mon, 16 Oct 2006 16:40:06 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

+static int marvell_pre_reset(struct ata_port *ap)
+{
+ struct pci_dev *pdev = to_pci_dev(ap->host->dev);
+ u32 devices;
+ unsigned long bar5;
+ void __iomem *barp;
+ int i;
+
+ /* Check if our port is enabled */
+
+ bar5 = pci_resource_start(pdev, 5);
+ barp = ioremap(bar5, 0x10);

hm. pci_resource_start() returns a possibly-64-bit resource_size_t
nowadays. But ioremap() doesn't know how to remap such a thing.

These days, pci_iomap() should be used anyway.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/