Re: [PATCH 1 of 2] fsstack: Introduce fsstack_copy_{attr,inode}_*

From: Jan Engelhardt
Date: Tue Oct 17 2006 - 06:55:40 EST



>To: null@xxxxxxxxxxxxxx

(Superb idea to prekill any Cc, re-adding them)

>+void __fsstack_copy_attr_all(struct inode *dest,
>+ const struct inode *src,
>+ int (*get_nlinks)(struct inode *))
>+{
>[big]
>+}
>+
>+/* externs for fs/stack.c */
>+extern void __fsstack_copy_attr_all(struct inode *dest,
>+ const struct inode *src,
>+ int (*get_nlinks)(struct inode *));
>+
>+static inline void fsstack_copy_attr_all(struct inode *dest,
>+ const struct inode *src)
>+{
>+ __fsstack_copy_attr_all(dest, src, NULL);
>+}

Do we really need this indirection? Can't __fsstack_copy_attr_all be
named fsstack_copy_attr_all instead?


-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/