Re: [PATCH] sata_nv ADMA/NCQ support for nForce4

[Mark Lord]

Robert Hancock wrote:
> Mark Lord wrote:
> > Robert Hancock wrote:
> > > +/* ADMA Physical Region Descriptor - one SG segment */
> > > +struct nv_adma_prd {
> > > +    __le64            addr;
> > > +    __le32            len;
> > > +    u8            flags;
> > > +    u8            packet_len;
..
> > > +struct nv_adma_cpb {
> > > +    u8            resp_flags;    //0
> > > +    u8            reserved1;     //1
> > > +    u8            ctl_flags;     //2
> > > +    // len is length of taskfile in 64 bit words
> > > +     u8            len;           //3 +    u8            
> > > tag;           //4
> > > +    u8            next_cpb_idx;  //5
> ..
> > Are those CPB / PRD structs endian-safe when using a big-endian CPU?
> >
> > Cheers
>
> They should be, I believe cpu_to_leXX is used whenever the multi-byte 
> elements are being written. 

I was thinking more about the non wordsized fields,
such as the various u8 bytes that gcc will lay out differently
depending upon endianess.

Cheers

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/