Re: Linux ISO-9660 Rock Ridge bug needs fix

From: Bodo Eggert
Date: Tue Oct 17 2006 - 19:13:26 EST


Luca Tettamanti <kronos.it@xxxxxxxxx> wrote:

> +++ b/fs/isofs/rock.c

> +
> + /* Rock Ridge V1.12, override inode number */
> + if (rr->len == 44)
> + inode->i_ino = isonum_733(rr->u.PX.inode);

I think it's wrong again, it will break as soon as rockridge 1.13 defines
an additional field. s,==,>=, should do the trick.

BTW and without digging in the code: Since version 2 will be binary
incompatible, is there a version check?

BTW2, Just to be cautionous: what will happen if somebody forces the same
inode number on two different entries?
--
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/