Re: Intel 965G: i915_dispatch_cmdbuffer failed (2.6.19-rc2)

From: Dave Airlie
Date: Wed Oct 18 2006 - 03:01:41 EST



Does the DRM git tree work would also be interesting,...

I haven't merged up Michel's drawable/blank changes for 2.6.19 as they were much too new for it, but do we have a backwards compat issue perhaps or something similiar?

Dave.

On Wed, 18 Oct 2006, Keith Whitwell wrote:

This is all a little confusing as the driver doesn't really use that
path in normal operation except for a single command - MI_FLUSH, which
is shared between the architectures. In normal operation the hardware
does the validation for us for the bulk of the command stream. If there
were missing functionality in that ioctl, it would be failing
everywhere, not just in this one case.

I guess the questions I'd have are
- did the driver work before the kernel upgrade?
- what path in userspace is seeing you end up in this ioctl?
- and like Keith, what commands are you seeing?

The final question is interesting not because we want to extend the
ioctl to cover those, but because it will give a clue how you ended up
there in the first place.

Keith

Keith Packard wrote:
On Tue, 2006-10-17 at 13:40 -0400, Ryan Richter wrote:

So do I want something like


static int do_validate_cmd(int cmd)
{
return 1;
}

in i915_dma.c?

that will certainly avoid any checks. Another alternative is to printk
the cmd which fails validation so we can see what needs adding here.



------------------------------------------------------------------------

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642


------------------------------------------------------------------------

--
_______________________________________________
Dri-devel mailing list
Dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/dri-devel


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/dri-devel


--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
Linux kernel - DRI, VAX / pam_smb / ILUG

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/