Re: veth crash (commit 751ae21c6cd1493e3d0a4935b08fb298b9d89773)

From: Santiago Leon
Date: Wed Oct 18 2006 - 12:22:44 EST


David Gibson wrote:
Jeff, Santiago, please apply the patch below to correct this:

ibmveth: Fix index increment calculation

The recent commit 751ae21c6cd1493e3d0a4935b08fb298b9d89773 introduced
a bug in the producer/consumer index calculation in the ibmveth driver
- incautious use of the post-increment ++ operator resulted in an
increment being immediately reverted. This patch corrects the logic.

Without this patch, the driver oopses almost immediately after
activation on at least some machines.

Signed-off-by: David Gibson <dwg@xxxxxxxxxxx>

David, I'm not sure how it got past the testing that I did, but thanks for catching this.

Jeff, can you apply? Thank you.

Signed-off-by: Santiago Leon <santil@xxxxxxxxxx
--
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/