Re: [PATCH 4/6] net: use bitrev8

[Andrew Morton]

On Thu, 19 Oct 2006 01:46:47 +0900
Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers.
> 
> Cc: Jeff Garzik <jgarzik@xxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Mirko Lindner <mlindner@xxxxxxxxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> 
>  drivers/net/Kconfig        |    1 
>  drivers/net/bmac.c         |   20 ++--------
>  drivers/net/mace.c         |   16 +-------
>  drivers/net/macmace.c      |   18 +--------
>  drivers/net/macsonic.c     |    6 ---
>  drivers/net/skfp/can.c     |   83 ---------------------------------------------
>  drivers/net/skfp/drvfbi.c  |   21 ++++-------
>  drivers/net/skfp/fplustm.c |    4 +-
>  drivers/net/skfp/smt.c     |    7 +--

A bunch of drivers.

> ===================================================================
> --- work-fault-inject.orig/drivers/net/Kconfig
> +++ work-fault-inject/drivers/net/Kconfig
> @@ -2500,6 +2500,7 @@ config DEFXX
>  config SKFP
>  	tristate "SysKonnect FDDI PCI support"
>  	depends on FDDI && PCI
> +	select BITREVERSE
>  	---help---
>  	  Say Y here if you have a SysKonnect FDDI PCI adapter.
>  	  The following adapters are supported by this driver:

But only one of them selects the library.

The patchset adds a large number of `select' statements.  afaict everything
_seems_ to work OK with that (as long as all the needed selects are there).

But select is problematic and I do wonder whether it'd be simpler to just
link the thing into vmlinux.

Oh well, we'll see how it goes.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/