Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.

From: Amit Choudhary
Date: Fri Oct 20 2006 - 19:27:34 EST


>
> If you know se401->sbuf[] and se401->scratch , urb etc are being cleared
> to NULL (or you did that) you could just use the kfree loops in nomem_
> for all cases as kfree(NULL) is an allowed "no-op"
>
>

In se401_stop_stream(), se401->sbuf[i].data is kfreed but not set to NULL. So, I could have
changed it there. But then I decided not to depend on anything else and do everything in
se401_start_stream(). But if this approach is wrong then please let me know.

Regards,
Amit

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/