Re: 2.6.19-rc2-mm2 : empty files on vfat file system

[OGAWA Hirofumi]

Andrew Morton <akpm@xxxxxxxx> writes:

> On Sat, 21 Oct 2006 19:38:49 +0200
> Damien Wyart <damien.wyart@xxxxxxx> wrote:
>
>> > --- a/fs/fat/inode.c~fs-prepare_write-fixes
>> > +++ a/fs/fat/inode.c
>> > @@ -150,7 +150,11 @@ static int fat_commit_write(struct file 
>> >  			    unsigned from, unsigned to)
>> >  {
>> >  	struct inode *inode = page->mapping->host;
>> > -	int err = generic_commit_write(file, page, from, to);
>> > +	int err;
>> > +	if (to - from > 0)
>> > +		return 0;
>> > +
>
> That should have been
>
> 	if (to - from == 0)
> 		return 0;

As I said in this thread, generic_cont_expand() uses "to == from".
Should we fix generic_cont_expand() instead? I don't know the
background of this patch.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/