Re: Hopefully, kmalloc() will always succeed, but if it doesn't then....

From: Amit Choudhary
Date: Sun Oct 22 2006 - 19:10:47 EST




--- Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:

>
> $ make -C /erk/kernel/linux-2.6.19-rc2 M=$PWD
> CC [M] /dev/shm/test.o
> /dev/shm/test.c: In function â??funcâ??:
> /dev/shm/test.c:4: warning: â??bâ?? may be used uninitialized in this
> function
>

It would be nice if this warning can be seen in all the cases without doing anything extra. But
sometimes I do not see it.

I compiled sound/pci/mixart/mixart_hwdep.c - did "make modules".

It has the following code but I did not get any warnings.

static int mixart_enum_connectors(struct mixart_mgr *mgr)
{
u32 k;
int err;
struct mixart_msg request;
struct mixart_enum_connector_resp *connector;
struct mixart_audio_info_req *audio_info_req;
struct mixart_audio_info_resp *audio_info;

connector = kmalloc(sizeof(*connector), GFP_KERNEL);
audio_info_req = kmalloc(sizeof(*audio_info_req), GFP_KERNEL);
audio_info = kmalloc(sizeof(*audio_info), GFP_KERNEL);
if (! connector || ! audio_info_req || ! audio_info) {
err = -ENOMEM;
goto __error;
}

root@zephyr-7 linux-2.6.19-rc1]# make modules
scripts/kconfig/conf -s arch/i386/Kconfig
CHK include/linux/version.h
CHK include/linux/utsrelease.h
...
CC [M] sound/pci/mixart/mixart.o
CC [M] sound/pci/mixart/mixart_core.o
CC [M] sound/pci/mixart/mixart_hwdep.o
CC [M] sound/pci/mixart/mixart_mixer.o
LD [M] sound/pci/mixart/snd-mixart.o
Building modules, stage 2.
MODPOST 44 modules
CC sound/core/snd-hwdep.mod.o
LD [M] sound/core/snd-hwdep.ko
...
[root@zephyr-7 linux-2.6.19-rc1]#

Regards,
Amit



__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/