Re: [PATCH] fix minor error about efi memory_present

From: Andrew Morton
Date: Mon Oct 23 2006 - 00:45:51 EST


On Mon, 23 Oct 2006 11:42:33 +0800
"bibo,mao" <bibo.mao@xxxxxxxxx> wrote:

> Hi,
> Function efi_memory_present_wrapper parameter start/end is physical address,
> but function memory_present parameter is PFN, this patch converts physical
> address to PFN.
>
> Signed-off-by: bibo, mao <bibo.mao@xxxxxxxxx>
>
> thanks
> bibo,mao
>
> diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
> index 519e63c..141041d 100644
> --- a/arch/i386/kernel/setup.c
> +++ b/arch/i386/kernel/setup.c
> @@ -846,7 +846,7 @@ efi_find_max_pfn(unsigned long start, un
> static int __init
> efi_memory_present_wrapper(unsigned long start, unsigned long end, void *arg)
> {
> - memory_present(0, start, end);
> + memory_present(0, PFN_UP(start), PFN_DOWN(end));
> return 0;
> }
>

It doesn't _seem_ like a "minor error". How come people's machines haven't
been crashing all over the place?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/