Re: [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix

From: Jan-Bernd Themann
Date: Thu Oct 26 2006 - 09:52:22 EST


Hi,

that is right, I'll send a new patch

Thanks,
Jan-Bernd

On Wednesday 25 October 2006 18:21, Anton Blanchard wrote:
>
> Hi,
>
> > +#ifdef CONFIG_PPC_64K_PAGES
> > + /* To support 64k pages we must round to 64k page boundary */
> > + epas->kernel.addr =
> > + ioremap((paddr_kernel & 0xFFFFFFFFFFFF0000), PAGE_SIZE) +
> > + (paddr_kernel & 0xFFFF);
> > +#else
> > epas->kernel.addr = ioremap(paddr_kernel, PAGE_SIZE);
> > +#endif
>
> Cant you just use PAGE_MASK, ~PAGE_MASK and remove the ifdefs
> completely?
>
> Anton
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/