Re: [PATCH cciss: fix printk format warning

[Andrew Morton]

On Mon, 23 Oct 2006 21:46:08 -0700
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> --- linux-2619-rc3-pv.orig/drivers/block/cciss.c
> +++ linux-2619-rc3-pv/drivers/block/cciss.c
> @@ -1992,8 +1992,8 @@ cciss_read_capacity(int ctlr, int logvol
>  		*block_size = BLOCK_SIZE;
>  	}
>  	if (*total_size != (__u32) 0)

Why is cciss_read_capacity casting *total_size to u32?

It is a sector_t.  If it happens to have the value 0xnnnnnnnn00000000 then
this expression will incorrectly evaluate to `false'.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/