Re: [PATCH] rename net_random to random32

From: Christoph Hellwig
Date: Sat Oct 28 2006 - 12:50:56 EST


On Fri, Oct 13, 2006 at 08:19:22PM +0200, Adrian Bunk wrote:
> > --- /dev/null
> > +++ b/lib/random32.c
> >...
> > +EXPORT_SYMBOL(random32);
> >...
> > +EXPORT_SYMBOL(srandom32);
> >...
>
> EXPORT_SYMBOL's in lib-y are latent bugs (IMHO kbuild should error
> on them):
>
> The problem is that if only modules use these functions, they will be
> omitted from the kernel image.

In fact we should really really just kill lib-y completely. Leaving
the control of what gets built in to the linker shound like a really
bad idea in our enviroment.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/