Re: 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state

[Ingo Molnar]

* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> >  	struct rb_node *parent;
> >  	struct cfq_io_context *__cic;
> > +	unsigned long flags;
> >  	void *k;
> >  
> >  	cic->ioc = ioc;
> > @@ -1384,9 +1385,9 @@ restart:
> >  	rb_link_node(&cic->rb_node, parent, p);
> >  	rb_insert_color(&cic->rb_node, &ioc->cic_root);
> >  
> > -	spin_lock_irq(cfqd->queue->queue_lock);
> > +	spin_lock_irqsave(cfqd->queue->queue_lock, flags);
> >  	list_add(&cic->queue_list, &cfqd->cic_list);
> > -	spin_unlock_irq(cfqd->queue->queue_lock);
> > +	spin_unlock_irqrestore(cfqd->queue->queue_lock, flags);
> >  }
> 
> this looks entirely reasonable and correct
> 
> Acked-By: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

yep.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/