Fw: [PATCH] SCSI: ISCSI build failure

From: Randy Dunlap
Date: Mon Oct 30 2006 - 23:55:55 EST



We need this patch that I sent to linux-scsi earlier today
in 2.6.19...

I suppose James is traveling or something.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Date: Mon, 30 Oct 2006 08:32:30 -0800
From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
To: Roman Zippel <zippel@xxxxxxxxxxxxxx>, jejb <james.bottomley@xxxxxxxxxxxx>
Cc: Toralf F_rster <toralf.foerster@xxxxxx>, scsi <linux-scsi@xxxxxxxxxxxxxxx>, akpm <akpm@xxxxxxxx>
Subject: [PATCH] SCSI: ISCSI build failure


On Mon, 30 Oct 2006 12:07:48 +0100 (CET) Roman Zippel wrote:

> Hi,
>
> On Sun, 29 Oct 2006, Randy Dunlap wrote:
>
> > On Sun, 29 Oct 2006 19:45:15 +0100 Toralf Förster wrote:
> >
> > > Hello,
> >
> > config SCSI_ISCSI_ATTRS
> > tristate "iSCSI Transport Attributes"
> > depends on SCSI && NET
> > help
> > If you wish to export transport-specific information about
> > each attached iSCSI device to sysfs, say Y.
> > Otherwise, say N.
> >
> > but NET is disabled, yet somehow SCSI_ISCSI_ATTRS is enabled.
> > I don't see how that happens.
> > Roman, any ideas?
> >
> > [...]
> > > CONFIG_SCSI_QLA_ISCSI=y
>
> I guess, that needs a dependency on NET.

Yep, thanks, Roman.

James, should be in 2.6.19...

---

From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

SCSI_QLA_ISCSI needs to depend on NET to prevent build (link) failures
that are caused by selecting SCSI_ISCSI_ATTRS.

Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
---
drivers/scsi/qla4xxx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.19-rc3-git6.orig/drivers/scsi/qla4xxx/Kconfig
+++ linux-2.6.19-rc3-git6/drivers/scsi/qla4xxx/Kconfig
@@ -1,6 +1,6 @@
config SCSI_QLA_ISCSI
tristate "QLogic ISP4XXX host adapter family support"
- depends on PCI && SCSI
+ depends on PCI && SCSI && NET
select SCSI_ISCSI_ATTRS
---help---
This driver supports the QLogic 40xx (ISP4XXX) iSCSI host
-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/