Re: [PATCH 1/2] taskstats: factor out reply assembling

[Oleg Nesterov]

On 11/02, Balbir Singh wrote:
>
> Oleg Nesterov wrote:
> > +
> > +	aggr = TASKSTATS_TYPE_AGGR_TGID;
> > +	if (type == TASKSTATS_TYPE_PID)
> > +		aggr = TASKSTATS_TYPE_AGGR_PID;
> 
> How about using
> 
> aggr = (type == TASKSTATS_TYPE_PID) ? TASKSTATS_TYPE_AGGR_PID  :
> 				TASKSTATS_TYPE_AGGR_TGID;

I personally think this is much better. In fact, i did exactly same, but
then changed it because (I think) CodingStyle police doesn't like '?:'.

Or it does?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/