Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control blockin 64k page mode

From: Hoang-Nam Nguyen
Date: Mon Nov 06 2006 - 05:36:45 EST


Hi Roland!
> Arnd wrote:
> This seems broken. You have a constructor for newly allocated objects,
but
> there is no destructor and it seems that objects passed to
> ehca_free_fw_ctrlblock are not guaranteed to be initialized either.
> I'd simply move the memset into the alloc function and get rid of the
> constructor here.
As Arnd stated I need to fix this ctor issue. Do you prefer me to resend
all patches in proper format (non-mangled inline) or just this one bug fix?
Thanks!
Nam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/