Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

From: Roland Dreier
Date: Mon Nov 06 2006 - 11:51:14 EST


> I'd simply move the memset into the alloc function and get rid of the
> constructor here.

Slightly better still would be to use kmem_cache_zalloc() (save a tiny
bit of text by getting rid of the call to memset).

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/