[PATCH 3/3] new_inode_autonum: fix up possible i_ino collision insimple_fill_super()

From: Jeff Layton
Date: Thu Nov 09 2006 - 10:26:24 EST


simple_fill_super() looked like a bug waiting to happen. It is fairly hard to
trigger, but still. This should fix it, although in a fairly crude manner.

Signed-off-by: JÃrn Engel <joern@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

diff --git a/fs/libfs.c b/fs/libfs.c
index bd08e0e..477c012 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -373,6 +373,10 @@ int simple_fill_super(struct super_block
inode = new_inode(s);
if (!inode)
return -ENOMEM;
+ /* ino must not collide with any ino assigned in the loop below.
+ * This value is arbitrary but should be "big enough" to avoid
+ * collisions. */
+ inode->i_ino = 0x8000000;
inode->i_mode = S_IFDIR | 0755;
inode->i_uid = inode->i_gid = 0;
inode->i_blocks = 0;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/