Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification
From: Badari Pulavarty
Date: Thu Nov 09 2006 - 20:52:53 EST
Sébastien Dugué wrote:
AIO completion signal notification
+
+ /* Release task ref */
+ if (req->ki_notify.notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID))
+ put_task_struct(req->ki_notify.target);
+
Huh ?? I thought user can set SIGEV_SIGNAL or SIGEV_THREAD_ID.
Not both. Isn't it ? Shouldn't this be ?
if ((req->ki_notify.notify == SIGEV_SIGNAL) ||
(req->ki_notify.notify == SIGEV_THREAD_ID))
...
Samething in get_task_struct() also..
Thanks,
Badari
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/