Re: [PATCH] gx-suspmod: fix "&& 0xff" typo

[Horst H. von Brand]

Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> >  > > -	params->pci_rev = class_rev && 0xff;
> >  > > +	params->pci_rev = class_rev & 0xff;
> >  >
> >  > Hi,
> >  > any kind of automated detection on that one?
> >
> > grep -r "&& 0x" .  seems to be pretty effective modulo
> > some false-positives.
> 
> Obligatory nit-picking:
> 
> 	grep '&&[ 	]*0[xX][fF]' -r .

Hum... could also be, e.g., "&& 1 << 3", or "&& SOME_FUNKY_CONSTANT"...

        grep -r '&&[    ]*[0-9A-Z]'

but that gives lots of noise... need to refine (or just eyeball the
output). OK, will check.
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/