Re: [PATCH] autofs4 - panic after mount fail

[David Howells]

Ian Kent <raven@xxxxxxxxxx> wrote:

> -	if (sbi->pipe) {
> -		fput(sbi->pipe);	/* Close the pipe */
> -		sbi->pipe = NULL;
> -	}
> +	fput(sbi->pipe);	/* Close the pipe */
> +	sbi->pipe = NULL;

Ummm...  Is that right?  fput() doesn't check its argument for a NULL pointer,
so the original code shouldn't hurt and should give you an extra bit of
defense.

Other than that, it looks reasonable.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/