Re: [PATCH 2.6.19-rc5] hwmon: HP Mobile data protection system 3D driver version 0.5

[Dmitry Torokhov]

On 11/14/06, Burman Yan <yan_952@xxxxxxxxxxx> wrote:
> Hi.
>
> I took into account previous remarks, so here is the new version of the
> driver
> for the accelerometer present in HP nc6400 laptops. See documentation in the
> patch
> for complete feature list. At this point I don't think there is anything
> more that can
> be added to this driver and also it works stable for me no matter how I
> tried to abuse it.

Hi,

I don't think that you need a spinlock to protect mdps.count. Just
make it atomic_t and use atomic_xchg(&mdps.count, 0) in
mdaps_misc_read to get and reset it.

Also why are you settng EV_KEY bit on the input device? You are not
reporintg any key events...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/