Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

[Jeff Garzik]

Stephen Hemminger wrote:
> On Tue, 14 Nov 2006 23:24:04 -0500
> Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
> > David Miller wrote:
> > > Is this absolutely true?  I've never been sure about this point, and I
> > > was rather convinced after reading various documents that once you
> > > program up the MSI registers to start generating MSI this implicitly
> > > disabled INTX and this was even in the PCI specification.
> > >
> > > It would be great to get a definitive answer on this.
> > >
> > > If it is mandatory, perhaps the driver shouldn't be doing it and
> > > rather the PCI layer MSI enabling should.
>
> pci_enable_msi() calls msi_capability_init() and that disables intx
> already.
[...]
> The driver shouldn't deal with this, pci_disable_msi() does.

Explicit code reference please?

AFAICS the PCI layer only touched INTx bit for PCI-Express devices.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/