Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors

From: David Brownell
Date: Wed Nov 15 2006 - 18:45:41 EST


On Wednesday 15 November 2006 6:48 am, Alexey Starikovskiy wrote:
> ec1.patch
>
>
> Always enable GPE after return from notify handler.
>
> From:  Alexey Starikovskiy <alexey.y.starikovskiy@xxxxxxxxxxxxxxx>
>
>
> ---

Yes, this seems to resolve the regression as well as Len's ec_intr=0 boot param.

IMO this should get merged into 2.6.19 ASAP ...


>  drivers/acpi/ec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index e6d4b08..937eafc 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -465,8 +465,6 @@ static u32 acpi_ec_gpe_handler(void *dat
>  
>         if (value & ACPI_EC_FLAG_SCI) {
>                 status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
> -               return status == AE_OK ?
> -                   ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
>         }
>         acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
>         return status == AE_OK ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/