Re: [patch, -rc6] x86_64: UP build fixes

[Andrew Morton]

On Thu, 16 Nov 2006 09:48:55 +0100
Ingo Molnar <mingo@xxxxxxx> wrote:

> +static inline int
> +smp_call_function_single(int cpuid, void (*func) (void *info), void *info,
> +			 int retry, int wait)
> +{
> +	func(info);
> +
> +	return 0;
> +}
> +

Given that on SMP the function is called with local interrupts disabled,
I'd suggest that it should be called with local interrupts disabled on UP
as well.

on_each_cpu() does this and one caller (at least) relies upon it
(invalidate_bh_lrus(), iirc).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/