Re: [PATCH] ext3: htree entry integrity checking

From: Andreas Dilger
Date: Thu Nov 16 2006 - 17:28:10 EST


On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote:
> Currently, if a corrupted directory entry with rec_len=0 is encountered,
> we still trust that the data is valid. This can cause an infinite loop
> in htree_dirblock_to_tree() since the iteration loop will never make any
> progress.

Actually, I think Eric Sandeen was working on similar fixes already, and
instead of doing a per-item check each time we look at the entry it does
a full-block check the first time it is read (as ext2 does).

> This fixes the problem described at:
> http://projects.info-pull.com/mokb/MOKB-10-11-2006.html

Would also be good to CC linux-ext4, where the ext3 maintainers live.
Hmm, maybe we need to update MAINTAINERS with the new list address?

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/