Re: [PATCH 9/20] x86_64: 64bit PIC SMP trampoline

[Pavel Machek]

On Fri 2006-11-17 19:33:52, Vivek Goyal wrote:
> On Sat, Nov 18, 2006 at 01:27:10AM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > that long mode is supported.  Asking if long mode is implemented is
> > > down right silly but we have traditionally had some of these checks,
> > > and they can't hurt anything.  So when the totally ludicrous happens
> > > we just might handle it correctly.
> > 
> > Well, it is silly, and it is 50 lines of dense assembly. can we get
> > rid of it or get it shared with bootup version?
> > 
> 
> Hi Pavel,
> 
> Last patch in the series (patch 20)  already does that. That patch just
> puts all the assembly at one place which everybody shares. 
> 
> I know it is bad to introduce and delete your own code, but I kept that
> patch as last patch as all the other patches have got fair bit of testing
> in RHEL kernels and I wanted to make sure that if last patch breaks something
> problem can be isolated relatively easily.

Ahha, okay. ACK, then.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/